Refactor AuthCredentials #3
Conversation
HomayoonAlimohammadi
changed the title
juju-solutions with charmed-kubernetes in the URL
HomayoonAlimohammadi
changed the title
juju-solutions with charmed-kubernetes in the URL
| kubelet_token: str | ||
| proxy_token: str | ||
| client_token: str |
There was a problem hiding this comment.
Are these tokens going to be encoded?
There was a problem hiding this comment.
I don't think so, I just created this model because I have personal issues with a type-unsafe dict :D
There was a problem hiding this comment.
That'll be the go developer in you :D
| @@ -139,3 +149,21 @@ def get_ca_certificate(self, model: ops.Model) -> Optional[bytes]: | |||
| return secret.get_content(refresh=True)["ca-certificate"].encode() | |||
| except ops.SecretNotFoundError: | |||
| return None | |||
|
|
|||
|
|
|||
| class AuthCredentials(BaseModel): | |||
There was a problem hiding this comment.
Are there any tests around getting and setting these AuthCredentials?
There was a problem hiding this comment.
I think there is. The only thing that we use from that AuthCredentials is the client_token field, and that field is used to populate the token in the created kubeconfig. We have a test covering it here: https://github.com/charmed-kubernetes/interface-kube-control/blob/main/ops/tests/unit/test_ops_requires.py#L157
Overview
juju-solutionswithcharmed-kubernetesin the URL of the setup file.AuthCredentials