fix(lint): set core.autocrlf to input #178
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aymanbagabas
approved these changes
Nov 1, 2024
There was a problem hiding this comment.
Oh wow, this is super! @ldez Thank you so much for your help here, and for your open source work. Specifically, golangci-lint and go-acme/lego.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
My PR #177 proves that the problem on Windows is not intermittent but consistent.
My initial guess was a problem with CRLF (Windows style) and I was right.
The problem is related to the git configuration
core.autocrlf, by default, the GitHub Action on Windows usescore.autocrlf=true.LF is converted to CRLF, and this produces file differences, so formatter like gofmt/gofumpt will report a problem.
Demo:
Related to golangci/golangci-lint#4004 (comment)