Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Gum choose doesn't respect esc anymore #675

Open
aymanbagabas opened this issue Sep 12, 2024 · 1 comment
Open

Gum choose doesn't respect esc anymore #675

aymanbagabas opened this issue Sep 12, 2024 · 1 comment
Assignees
@aymanbagabas
Labels
bug Something isn't working cmd/choose

Comments

@aymanbagabas
Copy link
Member

aymanbagabas commented Sep 12, 2024 •
edited
Loading

Describe the bug
Gum v0.13 used to quit on esc

To Reproduce
Steps to reproduce the behavior:

  1. Run gum choose ...
  2. Press esc
  3. Gum choose should exit

Expected behavior
Gum choose should exit on esc
@aymanbagabas aymanbagabas self-assigned this Sep 12, 2024
@meowgorithm
Copy link
Member

I think that makes sense (probably for all TUI subcommands), however in this case I think the workflow should be:

  • If the user is actively typing in a filter esc sets the filter (as it works currently)
  • If a filter is set esc clears the filter (as it works currently)
  • If no filter is set esc exits the TUI

@caarlos0 caarlos0 added the bug Something isn't working label Nov 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@aymanbagabas aymanbagabas

Labels
bug Something isn't working cmd/choose
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@meowgorithm @caarlos0 @aymanbagabas