Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dummy SPM targets with no headers fail with error - fail("No header files were provided.") #1187

Open
mikhailmulyar opened this issue Jul 31, 2024 · 4 comments
Labels
bug Something isn't working

Comments

@mikhailmulyar
Copy link

mikhailmulyar commented Jul 31, 2024

After updating to version 0.34 of rules_swift_package_manager some SPM libs stopped to work with following error
fail("No header files were provided.")
For example it appears when trying to add aws_sdk.
It seems in all cases it happens because those sdks create dummy targets in their Package.swift file. Those targets contain only single empty.m file and binary dependencies. Rules_swift_package_manager can't find any headers while creating module map for those targets and fail with error.
https://github.com/aws-amplify/aws-sdk-ios-spm/blob/f7e79d076556210b1aec4289cc0028d7ac785959/Package.swift#L193

Are there any options to bypass this behaviour?

@cgrindel cgrindel added the bug Something isn't working label Aug 17, 2024
@cgrindel
Copy link
Owner

Sorry for the delay. I will need to investigate to better understand what is happening.

@kurtguenther
Copy link

Was this working in a previous version of rules_swift_package_manager? @mikhailmulyar

@mikhailmulyar
Copy link
Author

@kurtguenther Yes it worked in 0.22 at least, and 0.27 also I think

@cgrindel
Copy link
Owner

Sorry. I have not had time to investigate. If you can find where we perform the check, perhaps we can figure out what the right way forward is.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants