This repository has been archived by the owner on May 24, 2024. It is now read-only.
[form-single-select] Invalid example foucs and safari browser issue fixes #3902
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
saket2403
reviewed
Sep 7, 2023
Comment on lines
40
to
41
| --terra-form-select-single-select-invalid-focus-border-color: #004c76; | ||
| --terra-form-select-single-select-invalid-focus-box-shadow: 0 0 1px 3px #004c76, 0 0 7px 4px #004c76; |
There was a problem hiding this comment.
Were inputs from UX taken regarding these. On focus the red color disappears which does not seem correct
There was a problem hiding this comment.
These styles has been removed and added outline around the red colour border when it gets focussed. So that we can see the red colour border as usual with outline.
supreethmr
reviewed
Sep 7, 2023
| @@ -37,6 +37,8 @@ | |||
| --terra-form-select-invalid-focus-background-size: 0 0; | |||
| --terra-form-select-invalid-focus-border-color: #fb4c4c; | |||
| --terra-form-select-invalid-focus-box-shadow: 0 0 0 1px #fb4c4c, 0 0 0 1px #fb4c4c; | |||
| --terra-form-select-single-select-invalid-focus-border-color: #004c76; | |||
There was a problem hiding this comment.
style values are missing for orion-fusion-theme
There was a problem hiding this comment.
Above styles has been removed and added outline around the red colour border. Since there is no red colour border for invalid example in fusion theme, outline is not required so i have removed outline for fusion theme.
supreethmr
approved these changes
Sep 13, 2023
saket2403
approved these changes
Sep 13, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Invalid example focus issue - Previously, under 'Invalid' group 'Select a colour' combo box, Focus is not visible on Select a colour combo box. As a result Accessibility user unable to identify the focus. - It has fixed now.
Safari browser issue - Previously, In Safari browser when we bring focus on combobox and expand, and Press 'Escape' key to close combobox menu, browser is getting minimised - It has fixed now.
What was changed:
Added focus to the Invalid example.
Safari browser minimising issue has fixed.
Why it was changed:
Invalid example focus issue - As a result Accessibility user unable to identify the focus.
Safari browser issue - When we expand the combobox and press escape key browser shouldn't get minimised.
Testing
This change was tested using:
Reviews
In addition to engineering reviews, this PR needs:
Additional Details
This PR resolves:
UXPLATFORM-9570, 9572
Thank you for contributing to Terra.
@cerner/terra