From f87b44dc9a0043d7a4c44e2d6258ee48d74a2308 Mon Sep 17 00:00:00 2001 From: SM051274 Date: Fri, 1 Sep 2023 10:26:33 +0530 Subject: [PATCH 1/5] Updates Prop description --- packages/terra-form-radio/CHANGELOG.md | 3 +++ packages/terra-form-radio/src/Radio.jsx | 3 +++ 2 files changed, 6 insertions(+) diff --git a/packages/terra-form-radio/CHANGELOG.md b/packages/terra-form-radio/CHANGELOG.md index f8e42f4f936..a94ab5be294 100644 --- a/packages/terra-form-radio/CHANGELOG.md +++ b/packages/terra-form-radio/CHANGELOG.md @@ -2,6 +2,9 @@ ## Unreleased +* Changed + * Updated prop description for `isLabelHidden` prop. + ## 4.41.0 - (August 25, 2023) * Changed diff --git a/packages/terra-form-radio/src/Radio.jsx b/packages/terra-form-radio/src/Radio.jsx index 4fb52777770..18379b29414 100644 --- a/packages/terra-form-radio/src/Radio.jsx +++ b/packages/terra-form-radio/src/Radio.jsx @@ -35,6 +35,9 @@ const propTypes = { */ isInline: PropTypes.bool, /** + * ![IMPORTANT](https://badgen.net/badge/UX/Accessibility/blue) + * Radio button should always have visible label to meet WCAG 3.3.2 success criterion. + * When set to true, ensure meaningfull Text is provided for `labelText` prop. * Whether the label is hidden. */ isLabelHidden: PropTypes.bool, From 23eef4418ba65628998f1622f45370d6510ca87a Mon Sep 17 00:00:00 2001 From: SM051274 Date: Wed, 6 Sep 2023 21:29:35 +0530 Subject: [PATCH 2/5] added note --- .../example/radio/HiddenLabelRadioExample.jsx | 11 ++++++++++- 1 file changed, 10 insertions(+), 1 deletion(-) diff --git a/packages/terra-core-docs/src/terra-dev-site/doc/form-radio/example/radio/HiddenLabelRadioExample.jsx b/packages/terra-core-docs/src/terra-dev-site/doc/form-radio/example/radio/HiddenLabelRadioExample.jsx index 3f59036c479..637f8290ab6 100644 --- a/packages/terra-core-docs/src/terra-dev-site/doc/form-radio/example/radio/HiddenLabelRadioExample.jsx +++ b/packages/terra-core-docs/src/terra-dev-site/doc/form-radio/example/radio/HiddenLabelRadioExample.jsx @@ -1,6 +1,15 @@ import React from 'react'; import Radio from 'terra-form-radio'; -const hiddenLabelRadioExample = () => (); +const hiddenLabelRadioExample = () => ( +
+

+ Note: + Radio button should always have label to ensures that people with visual or cognitive disabilities will recognize radio buttons and understand what information to provide to fill in the fields. + For example: When we have radio feilds for selection of account types, authors may feel that just providing programmatically determined names of the fields will be sufficient to identify them. However, even if all the fields have programmatically determined names, a text label must also identify the set of fields as a account type. +

+ +
+); export default hiddenLabelRadioExample; From dd528fdd82594ac61d55f1d2e954a497899b2251 Mon Sep 17 00:00:00 2001 From: SM051274 Date: Wed, 6 Sep 2023 23:12:38 +0530 Subject: [PATCH 3/5] changelog update --- packages/terra-core-docs/CHANGELOG.md | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/packages/terra-core-docs/CHANGELOG.md b/packages/terra-core-docs/CHANGELOG.md index 7d090124ce8..1a8fd7e252a 100644 --- a/packages/terra-core-docs/CHANGELOG.md +++ b/packages/terra-core-docs/CHANGELOG.md @@ -1,11 +1,13 @@ # Changelog ## Unreleased + * Added * Added drag and drop example for `terra-list`. + * Added instruction note for `terra-form-radio` label hidden example * Updated - * Updated `terra-scroll` to add realistic examples. + * Updated `terra-scroll` to add realistic examples. * Updated all paginator examples to use meaningful titles. * Updated testing recommendations to use `jest.spyOn` instead of `jest.mock`. From 4e48ae62a2a1b38797b5137fac39f399663315a2 Mon Sep 17 00:00:00 2001 From: SM051274 Date: Thu, 7 Sep 2023 01:37:14 +0530 Subject: [PATCH 4/5] typo --- .../doc/form-radio/example/radio/HiddenLabelRadioExample.jsx | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/packages/terra-core-docs/src/terra-dev-site/doc/form-radio/example/radio/HiddenLabelRadioExample.jsx b/packages/terra-core-docs/src/terra-dev-site/doc/form-radio/example/radio/HiddenLabelRadioExample.jsx index 637f8290ab6..b70d9336e57 100644 --- a/packages/terra-core-docs/src/terra-dev-site/doc/form-radio/example/radio/HiddenLabelRadioExample.jsx +++ b/packages/terra-core-docs/src/terra-dev-site/doc/form-radio/example/radio/HiddenLabelRadioExample.jsx @@ -4,9 +4,10 @@ import Radio from 'terra-form-radio'; const hiddenLabelRadioExample = () => (

- Note: + Note: Radio button should always have label to ensures that people with visual or cognitive disabilities will recognize radio buttons and understand what information to provide to fill in the fields. - For example: When we have radio feilds for selection of account types, authors may feel that just providing programmatically determined names of the fields will be sufficient to identify them. However, even if all the fields have programmatically determined names, a text label must also identify the set of fields as a account type. +
+ For example: When we have radio fields for selection of account types, authors may feel that just providing programmatically determined names of the fields will be sufficient to identify them. However, even if all the fields have programmatically determined names, a text label must also identify the set of fields as a account type.

From fbcf19ed9b0b181842fff52da4dca5fb6de7d8a6 Mon Sep 17 00:00:00 2001 From: Saket Bajaj <42207428+saket2403@users.noreply.github.com> Date: Thu, 7 Sep 2023 10:26:03 +0530 Subject: [PATCH 5/5] Update packages/terra-form-radio/src/Radio.jsx --- packages/terra-form-radio/src/Radio.jsx | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/terra-form-radio/src/Radio.jsx b/packages/terra-form-radio/src/Radio.jsx index 18379b29414..1eb5a9a3529 100644 --- a/packages/terra-form-radio/src/Radio.jsx +++ b/packages/terra-form-radio/src/Radio.jsx @@ -37,7 +37,7 @@ const propTypes = { /** * ![IMPORTANT](https://badgen.net/badge/UX/Accessibility/blue) * Radio button should always have visible label to meet WCAG 3.3.2 success criterion. - * When set to true, ensure meaningfull Text is provided for `labelText` prop. + * When set to true, ensure meaningful Text is provided for `labelText` prop. * Whether the label is hidden. */ isLabelHidden: PropTypes.bool,