[terra-paginator] Styling update to support anchor attribute gap in F… #3900
Conversation
...-lowlight-theme/en/chrome_large/paginator-spec/progressive_paginator_fusion_anchor_style.png
Outdated
Show resolved
Hide resolved
chenyixuan625
force-pushed
the
UXPLATFORM-9527
branch
from
86402d0 to
1e77b7c
Compare
| /** | ||
| * Apply Fusion anchor style or not. | ||
| */ | ||
| fusionAnchor: PropTypes.bool, |
There was a problem hiding this comment.
It seems odd to add a prop for a very specific use case. Especially since it's related to theming. I'm confused why this is needed to be an API change and not a theme update or any other alternative solution.
cc: @JessieRandle , @mjpalazzo , @sycombs
There was a problem hiding this comment.
For the Orion fusion theme, there are 2 different styles(anchor and canvas) and we need to support both. So applying this new optional prop is to distinguish each other in the same fusion theme(and we keep the current Orion fusion theme to render the canvas style).
Any suggestions?
There was a problem hiding this comment.
If it's styling we need to support then I would say that we should support it for all themes and not add a niche prop that is only useful for a specific theme.
cc: @eawww , @mjpalazzo , @JessieRandle
scottwilmarth
added
⭐ UX Reviewed
|
Synced with Scott and Terra folks, we believe that the best practice would be that Fusion takes care of its own customized style. Adding a prop for a specific styling usage is very confusing for consumers. Closing this PR out. Will comment on the UXPLATFORM-9527 soon. |
…usion
Summary
What was changed:
A new optional boolean prop(false by default) is added to support the anchor style. When the new prop is set(true), the paginator will be rendered in a gray background color with a borderline at the top.
Why it was changed:
Currently the paginator renders without any borderline and the background color is white. However, MPage PagiantorFooter(utilizing Progressive Paginator) has an "anchor" style, which has a top borderline and the background color is gray. We will want to add a new optional boolean prop(false by default) to support the anchor style from the Terra perspective.
Testing
The default progressive paginator looks like(no top border line and no background color):
The progressive paginator with Fusion Anchor style(top border line and gray background color):
This PR does not contain Accessibility changes.
This change was tested using:
Reviews
In addition to engineering reviews, this PR needs:
Additional Details
This PR resolves:
UXPLATFORM-9527
Thank you for contributing to Terra.
@cerner/terra