Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] not compatible with React 19 #620

Open
hitbear518 opened this issue Dec 9, 2024 · 3 comments
Open

[BUG] not compatible with React 19 #620

hitbear518 opened this issue Dec 9, 2024 · 3 comments
Assignees
@christianalfoni
Labels
bug Something isn't working

Comments

@hitbear518
Copy link

due to use of SECRET_INTERNALS_DO_NOT_USE_OR_YOU_WILL_BE_FIRED, not compatible with React 19
@hitbear518 hitbear518 added the bug Something isn't working label Dec 9, 2024
@fmal
Copy link

fmal commented Dec 18, 2024 •
edited
Loading

@christianalfoni looks like the fix (at least so that overmind/react doesn't throw) would be quite easy: https://github.com/microsoft/use-disposable/pull/32/files#diff-5971f63da29997ff64996c0f14497c4756ed24cf15d181141ea6a8f9c8d7a376R6. Basically the internals have been moved around.

Would you be able to find some time to revive Overmind for React 19 so that this awesome project can live for some more time? :D We would all appreciate it ❤️

Hopefully, I will take my chances as well to try to send a PR that fixes this issue.

@henri-hulski
Copy link
Member

If you send a pr and everything looks good I can release it to next.

@fmal
Copy link

fmal commented Dec 18, 2024

@henri-hulski thx good to know, challenge accepted then 😃

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@christianalfoni christianalfoni

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@fmal @christianalfoni @hitbear518 @henri-hulski