Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dependency: Should not use different teuthology branch #9

Closed
zmc opened this issue Jul 25, 2023 · 2 comments · Fixed by #20 or #49
Closed

Dependency: Should not use different teuthology branch #9

zmc opened this issue Jul 25, 2023 · 2 comments · Fixed by #20 or #49
Assignees
Labels
dependency Dependency related stuff

Comments

@zmc
Copy link
Member

zmc commented Jul 25, 2023

zack@teuthology:~/teuthology-api$ grep teuthology requirements.txt
# Temporarily, using teuthology without monkey patching the thread
git+https://github.com/VallariAg/teuthology@teuth-api#egg=teuthology[test]
# Original: git+https://github.com/ceph/teuthology#egg=teuthology[test]

I didn't see a separate issue dedicated to this.

@VallariAg VallariAg linked a pull request Sep 12, 2023 that will close this issue
@zmc
Copy link
Member Author

zmc commented Oct 13, 2023

The change to use a branch in the ceph org's repo is positive, but doesn't quite resolve this. It may be the case that we could stop monkey patching threads in teuthology main, but we'd want to test that - otherwise, perhaps there's another way to make this work.

@zmc zmc reopened this Oct 13, 2023
@VallariAg VallariAg changed the title Should not use forked teuthology Dependency: Should not use different teuthology branch Nov 2, 2023
@VallariAg VallariAg added the dependency Dependency related stuff label Nov 2, 2023
@VallariAg VallariAg self-assigned this Feb 13, 2024
@VallariAg VallariAg linked a pull request Jul 9, 2024 that will close this issue
4 tasks
@VallariAg
Copy link
Member

We are using teuthology main branch now: #49

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependency Dependency related stuff
Projects
None yet
2 participants