Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Debug: protection in ntuple dump in FullLDCTrackingAlg (minor) #237

Open
qwert2333 opened this issue Dec 8, 2022 · 0 comments
Open

Debug: protection in ntuple dump in FullLDCTrackingAlg (minor) #237

qwert2333 opened this issue Dec 8, 2022 · 0 comments

Comments

@qwert2333
Copy link

Hi,

There seems a bug in FullLDCTrackingAlg when I disable dumping the ntuples (dumpTime=False):
- In line 246 and 582 if(m_tuple), which I think it's better to write as if(m_dumpTime && m_tuple) to avoid the break.
This is such a minor debug so I did not create a PR, maybe you can fix it sometime convenient.

Cheers,
Fangyi

*Code in git:
https://github.com/cepc/CEPCSW/blob/master/Reconstruction/Tracking/src/FullLDCTracking/FullLDCTrackingAlg.cpp#L246
https://github.com/cepc/CEPCSW/blob/master/Reconstruction/Tracking/src/FullLDCTracking/FullLDCTrackingAlg.cpp#L582

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant