Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for Python 3.13 #594

Merged
merged 2 commits into from
Oct 30, 2024
Merged

Add support for Python 3.13 #594

merged 2 commits into from
Oct 30, 2024

Conversation

alexted
Copy link
Contributor

@alexted alexted commented Oct 26, 2024

@alexted alexted changed the title Add Python 3.13 support Add support for Python 3.13 Oct 26, 2024
nycholas
nycholas reviewed Oct 27, 2024
View reviewed changes
Dockerfile.local Outdated Show resolved Hide resolved
@nycholas nycholas linked an issue Oct 27, 2024 that may be closed by this pull request
Add support to Python 3.13 #582
Closed
nycholas
nycholas requested changes Oct 27, 2024
View reviewed changes
Copy link
Member

@nycholas nycholas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Incredible! To ensure pipeline stability, I’m refactoring the tests and modifying the pre-release and release pipeline to guarantee that the generated packages are thoroughly tested. Before accepting this change, I will merge the PR. Additionally, I’d like to test the free-GIL feature in that version. This may take a few days. Thank you for your contribution!

@alexted alexted requested a review from nycholas October 27, 2024 13:12
nycholas
nycholas previously approved these changes Oct 28, 2024
View reviewed changes
@alexted alexted force-pushed the feature/add-support-Python-3.13 branch from 1e27404 to 4880227 Compare October 29, 2024 07:52
@alexted alexted requested a review from nycholas October 29, 2024 08:48
nycholas
nycholas reviewed Oct 29, 2024
View reviewed changes
.github/workflows/codeql_analysis.yml Outdated
python -m build
- name: Perform CodeQL Analysis
uses: github/codeql-action/analyze@v3
- name: Checkout repository
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Out of curiosity, what is this plugin/idea/config/something else that you are using to format the files?

Copy link
Contributor Author

@alexted alexted Oct 30, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

standard PyCharm feature

@nycholas
Copy link
Member

@alexted Because of the big changes that I did on master, some changes here are out of scope, if you don't mind, can I contribute to resolving the conflicts?

@alexted
Copy link
Contributor Author

alexted commented Oct 30, 2024 •
edited
Loading

Certainly, no problem!

@alexted
build: added new version of Python interpreter
1c994de 
# Conflicts:
#	.github/workflows/on_update.yml
#	.github/workflows/pre_release.yml
#	.github/workflows/tests.yml
#	Dockerfile.it
#	Dockerfile.local
#	examples/javascript/tox.ini
#	examples/minimal-async/tox.ini
#	examples/minimal/tox.ini
#	examples/modular/tox.ini
#	examples/multiplesite/tox.ini
#	examples/openrpc/tox.ini
#	requirements/typing.txt
#	src/flask_jsonrpc/contrib/browse/static/js/apps/browse/services.js
@alexted
tests: returned explicit indication of python interpreter version for…
de2750f 
… images in dockerfiles
@alexted alexted force-pushed the feature/add-support-Python-3.13 branch from 68d6a90 to e9d0545 Compare October 30, 2024 06:12
@alexted alexted requested a review from nycholas October 30, 2024 06:43
nycholas
nycholas reviewed Oct 30, 2024
View reviewed changes
pyproject.toml Outdated
"Topic :: Internet :: WWW/HTTP :: Dynamic Content",
"Topic :: Software Development :: Libraries :: Application Frameworks",
]
requires-python = ">=3.9"
dependencies = [
"Flask>=3.0.0,<4.0",
"typeguard==4.4.0",
"typeguard~=4.4.0",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Specify the exact version for stability. For example, the update from version 4.3.0 to 4.4.0 of the Typeguard library addressed an issue with list interpretation (see here), which subsequently caused tests to break (see here).

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For the all dependencies.

Copy link
Contributor Author

@alexted alexted Oct 30, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With this specification, only modification of the patch version (the third digit) is allowed. Patch versions should not and usually do not carry any breaking changes.
See https://packaging.python.org/en/latest/specifications/version-specifiers/#compatible-release

nycholas
nycholas requested changes Oct 30, 2024
View reviewed changes
Copy link
Member

@nycholas nycholas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please revert all changes that are not related to adding support for Python 3.13, including the *.html, *.txt, *.svg, *.md files, and so on. 🙏

@nycholas
Copy link
Member

Sorry for a lot of work, I hope you keep contributing. 🙏

@alexted alexted force-pushed the feature/add-support-Python-3.13 branch from e9d0545 to de2750f Compare October 30, 2024 12:25
@alexted
Copy link
Contributor Author

alexted commented Oct 30, 2024

Please revert all changes that are not related to adding support for Python 3.13, including the *.html, *.txt, *.svg, *.md files, and so on. 🙏

Sorry, I got carried away. That was a little over the top on my part. Oops.
I rolled back all the ‘unnecessary’ changes.

@alexted alexted requested a review from nycholas October 30, 2024 12:32
nycholas
nycholas approved these changes Oct 30, 2024
View reviewed changes
Copy link
Member

@nycholas nycholas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a million! 🚀

@nycholas nycholas merged commit 95810cf into cenobites:master Oct 30, 2024
11 checks passed
@alexted alexted deleted the feature/add-support-Python-3.13 branch November 3, 2024 13:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nycholas nycholas nycholas approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add support to Python 3.13
2 participants
@alexted @nycholas