Drop support for Python 3.8 #591
Conversation
alexted
changed the title
alexted
changed the title
tests/utils.py
Outdated
| from typing import Any | ||
|
|
||
|
|
||
| class EqMock: |
There was a problem hiding this comment.
It isn't being used in any place, you can remove this file.
There was a problem hiding this comment.
I thought you might need it in tests later on. Well, if not, I'll delete it.
| 'terminal_id': 1, | ||
| 'headers': { | ||
| 'User-Agent': EqMock(), |
|
There are doubts as to whether it is worth ‘spreading’ tests in different directories. In addition to the classic tests/ in the project, they are now also in /examples. And there is a lot of boilerplate code and copypaste there. Is it really a good idea? |
|
@alexted The issue here is that I never revisited the examples to test them and ensure they remain supported by the library as changes have occurred. I’m aware of the duplicate code, but I believe it’s necessary to keep everything testable. You can see the related issue here and the proposed solution here. |
|
@alexted If you have another approach for that, we can create a GitHub discussion topic and debate there, what do you think? |
Thanks, I'm looking into the links you shared, but I can't yet see the connection between the above problem and keeping examples up to date. I think it's really worth a separate discussion. At least in the context of how ci/cd and testing part in particular can be simplified by unifying and parameterising configuration and manifests. |
Python 3.8 is now officially EOL