Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Expressive Text Styles #1156

Closed
orion-cengage opened this issue Nov 1, 2023 · 3 comments · Fixed by #1167
Closed

Update Expressive Text Styles #1156

orion-cengage opened this issue Nov 1, 2023 · 3 comments · Fixed by #1167
Assignees
@chris-cedrone-cengage
Labels
feature request Functionality that you believe is missing that you want added react-magma-dom Tasks related to react-magma-dom

Comments

@orion-cengage
Copy link
Contributor

orion-cengage commented Nov 1, 2023 •
edited
Loading

A request has been made by Marketing to adjust the Expressive text styles in our next release.

New Desktop styles (font-size/line-height):

  • Heading 2XL = 64px/84px, 500 weight
  • Heading XL = 48px/64px, 600 weight
  • Heading L = 36px/48px, 600 weight
  • Heading M = 28px/40px, 600 weight
  • Heading S = 24px/32px, 500 weight
  • Heading XS = 20px/32px, 500 weight
  • Heading 2XS = 18px/24px, 500 weight
  • Body Large = 20px/32px, neutral-700 color

New Mobile styles (font-size/line-height):

  • Heading 2XL = 48px/64px, 500 weight
  • Heading XL = 36px/48px, 600 weight
  • Heading L = 28px/40px, 600 weight
  • Heading M = 24px/32px, 500 weight
  • Heading S = 20px/32px, 500 weight
  • Heading XS = 18px/24px, 500 weight
  • Heading 2XS = 16px/24px, 500 weight

Desktop

image

Mobile

image
@orion-cengage orion-cengage added react-magma-dom Tasks related to react-magma-dom feature request Functionality that you believe is missing that you want added labels Nov 1, 2023
@orion-cengage orion-cengage self-assigned this Nov 3, 2023
@silvalaura
Copy link
Collaborator

Release December or early January

@silvalaura silvalaura moved this from To Do to In Progress in React Magma Nov 30, 2023
Merged
4 tasks
@silvalaura silvalaura moved this from In Progress to Ready for Review in React Magma Dec 4, 2023
@silvalaura silvalaura linked a pull request Dec 4, 2023 that will close this issue
Fix - Updates to Expressive text styles #1167
Merged
4 tasks
@github-project-automation github-project-automation bot moved this from Ready for Review to Ready for QA in React Magma Dec 5, 2023
@silvalaura
Copy link
Collaborator

This CodeSandbox can be used to test all the updated Expressive styles: https://codesandbox.io/p/sandbox/expressivestyles-6yqwyv?file=%2Fexample.tsx%3A7%2C26

@orion-cengage
Copy link
Contributor Author

I haven't been able to get the codesandbox link to load, but I QA'd the DEV docs and they look good.

@orion-cengage orion-cengage moved this from Ready for QA to Done in React Magma Dec 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@chris-cedrone-cengage chris-cedrone-cengage

Labels
feature request Functionality that you believe is missing that you want added react-magma-dom Tasks related to react-magma-dom
Projects
React Magma
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix - Updates to Expressive text styles cengage/react-magma
3 participants
@orion-cengage @chris-cedrone-cengage @silvalaura