Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for Sveltekit Template #320

Open
wants to merge 8 commits into
base: main
Choose a base branch
from
Open

Conversation

Philix27
Copy link

@Philix27 Philix27 commented Nov 6, 2024

This PR resolves #313.

This template is designed to have only the essential packages neccessary for web3 connections.

Main implementation points to an external repository. If one is created for Celo Org, I can push it there.

Features

  • Wallet connection using web3Modal
  • Interact wallet/account details using wagmi core
  • Interact with Smart contact using wagmi core

Copy link

netlify bot commented Nov 6, 2024

👷 Deploy request for celo-composer pending review.

Visit the deploys page to approve it

Name Link
🔨 Latest commit 95f5798

@Philix27 Philix27 marked this pull request as draft November 8, 2024 08:24
@Philix27 Philix27 marked this pull request as draft November 8, 2024 08:24
@viral-sangani
Copy link
Contributor

Hey @Philix27 can you please also add Sveltekit code in this PR as well instead of linking it to your repo?
Sorry for late reply.

Copy link

socket-security bot commented Nov 28, 2024

No dependency changes detected. Learn more about Socket for GitHub ↗︎

👍 No dependency changes detected in pull request

@Philix27
Copy link
Author

I have moved the template to this repository. @viral-sangani

Socket Security is pointing to sveltekit core packages (sveltejs/kit, esbuild) needed to run the app. I feel we can let some of these packages pass through.

@Philix27
Copy link
Author

Philix27 commented Nov 29, 2024

Can we remove the use of template url and just clone a subdirectory from the packages folder in this repo. @viral-sangani

When the cli runs and Minipay is selected, an external repo is cloned instead of copying from the list of packages/app we have here.

@Philix27
Copy link
Author

Philix27 commented Dec 5, 2024

@viral-sangani

Any luck with reviewing this PR?

@Philix27 Philix27 marked this pull request as ready for review December 7, 2024 05:16
@viral-sangani
Copy link
Contributor

@Philix27 It does make sense to clone the sub directory rather than cloning from different URL, but we are trying to keep all the templates outside the celo composer repo and all the code components i.e. Basic React + Hardhat etc in the main repo.
How about this -

Initially we planned to keep the code here and give an option between ReactJS and Svelte, but looking at the requirement for svelte vs react in web3 development, we want to keep react as default options and svelte as a template which is maintained by community.

@Philix27
Copy link
Author

Philix27 commented Dec 10, 2024

@viral-sangani Okay, I tried pushing to the new repo but my access was denied. I can't even make a PR.

Screenshot 2024-12-10 at 13 32 58

@viral-sangani
Copy link
Contributor

@Philix27 Can you try now? You can fork the repo and then add your code and create PR to upstream.

@Philix27
Copy link
Author

@viral-sangani Okay, the Sveltekit template has been removed and a PR created.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature]: Add support for Sveltekit
2 participants