-
Notifications
You must be signed in to change notification settings - Fork 123
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for Sveltekit Template #320
base: main
Are you sure you want to change the base?
Conversation
👷 Deploy request for celo-composer pending review.Visit the deploys page to approve it
|
Hey @Philix27 can you please also add Sveltekit code in this PR as well instead of linking it to your repo? |
No dependency changes detected. Learn more about Socket for GitHub ↗︎ 👍 No dependency changes detected in pull request |
- change French toast to sonner-svelte
I have moved the template to this repository. @viral-sangani Socket Security is pointing to sveltekit core packages (sveltejs/kit, esbuild) needed to run the app. I feel we can let some of these packages pass through. |
Can we remove the use of template url and just clone a subdirectory from the packages folder in this repo. @viral-sangani When the cli runs and Minipay is selected, an external repo is cloned instead of copying from the list of packages/app we have here. |
Any luck with reviewing this PR? |
@Philix27 It does make sense to clone the sub directory rather than cloning from different URL, but we are trying to keep all the templates outside the celo composer repo and all the code components i.e. Basic React + Hardhat etc in the main repo.
Initially we planned to keep the code here and give an option between ReactJS and Svelte, but looking at the requirement for svelte vs react in web3 development, we want to keep react as default options and svelte as a template which is maintained by community. |
@viral-sangani Okay, I tried pushing to the new repo but my access was denied. I can't even make a PR. |
@Philix27 Can you try now? You can fork the repo and then add your code and create PR to upstream. |
@viral-sangani Okay, the Sveltekit template has been removed and a PR created. |
This PR resolves #313.
This template is designed to have only the essential packages neccessary for web3 connections.
Main implementation points to an external repository. If one is created for Celo Org, I can push it there.
Features