You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The comment states that data is duplicated in the square, but it's not. It would copy if the line did a copy rather than assigning, which only copies pointers to slices, rather than actual bytes in those slices.
As discussed with @adlerjohn in sync, the PR that was supposed to introduce the duplication but did not, in fact, achieve the goal and benchmark improvements there come from reduced allocations in other code parts.
The text was updated successfully, but these errors were encountered:
Wondertan
changed the title
Fix incorrect commen on datasquare
Fix incorrect comment on datasquareDec 16, 2023
The comment states that data is duplicated in the square, but it's not. It would copy if the line did a
copy
rather than assigning, which only copies pointers to slices, rather than actual bytes in those slices.As discussed with @adlerjohn in sync, the PR that was supposed to introduce the duplication but did not, in fact, achieve the goal and benchmark improvements there come from reduced allocations in other code parts.
The text was updated successfully, but these errors were encountered: