Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix incorrect comment on datasquare #280

Open
Wondertan opened this issue Dec 16, 2023 · 0 comments
Open

Fix incorrect comment on datasquare #280

Wondertan opened this issue Dec 16, 2023 · 0 comments

Comments

@Wondertan
Copy link
Member

Wondertan commented Dec 16, 2023

The comment states that data is duplicated in the square, but it's not. It would copy if the line did a copy rather than assigning, which only copies pointers to slices, rather than actual bytes in those slices.

As discussed with @adlerjohn in sync, the PR that was supposed to introduce the duplication but did not, in fact, achieve the goal and benchmark improvements there come from reduced allocations in other code parts.

@Wondertan Wondertan changed the title Fix incorrect commen on datasquare Fix incorrect comment on datasquare Dec 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant