Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moving nmt wrapper to the rsmt2d #248

Open
staheri14 opened this issue Jul 10, 2023 · 0 comments
Open

Moving nmt wrapper to the rsmt2d #248

staheri14 opened this issue Jul 10, 2023 · 0 comments

Comments

@staheri14
Copy link
Contributor

Problem

As part of this PR effort and for the purpose of testing, we replicated the nmtwrapper logic within the rsmt2d repository. Subsequently, suggestions were put forward to relocate this code entirely to the rsmt2d repository. The purpose of this issue is to address the aforementioned suggestion, examine the implications of this change, and notify relevant stakeholders accordingly.

Originally suggested by @evan-forbes and @Wondertan in these comments #242 (comment) and #242 (comment)

the only thing the wrapper imports is the consts, so maybe it makes sense to accept those consts as args, then move the entire wrapper here

Or why not move the wrapper here completely then?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant