Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EDS thread-safety #135

Open
Wondertan opened this issue Oct 5, 2022 · 1 comment
Open

EDS thread-safety #135

Wondertan opened this issue Oct 5, 2022 · 1 comment
Labels
enhancement New feature or request

Comments

@Wondertan
Copy link
Member

Right now, the EDS does not have any guarantees regarding thread safety for read and write operations. Users like celestia-node end up implementing custom synchronization solutions around EDS, while the best practice for Go is to have thread safety provided by the library.

The proposal is to add an additional SyncEDS wrapping the existing EDS structure extracted from the celestia-node. Alternatively, we can make the existing EDS synchronized by default.

@Wondertan Wondertan added the enhancement New feature or request label Oct 5, 2022
@Wondertan Wondertan self-assigned this Oct 5, 2022
@Wondertan
Copy link
Member Author

It's clear that we want this, the only question is how: a separate structure or by extending the existing one. My vote would be for the extension.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant