Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change shares package name to share #88

Closed
cmwaters opened this issue Jun 24, 2024 · 0 comments · Fixed by #90
Closed

Change shares package name to share #88

cmwaters opened this issue Jun 24, 2024 · 0 comments · Fixed by #90
Assignees
@cmwaters

Comments

@cmwaters
Copy link
Collaborator

Just one question, why is the package called shares and not share?

+1 I think it was accidentally called shares a long time ago (celestiaorg/celestia-app#627) and we just haven't made the breaking change to rename it to singular share.

Originally posted by @rootulp in #82 (comment)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cmwaters cmwaters

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore!: rename shares to share celestiaorg/go-square
1 participant
@cmwaters