Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add different types of validation methods to blob #69

Closed
cmwaters opened this issue Jun 12, 2024 · 2 comments
Closed

Add different types of validation methods to blob #69

cmwaters opened this issue Jun 12, 2024 · 2 comments

Comments

@cmwaters
Copy link
Collaborator

Besides Validate, the node needs two more validate funcs. https://github.com/celestiaorg/celestia-node/blob/540192259c144ccbd24e45e34616a41389232a51/share/namespace.go#L114-L129.

We need this so we can restrict to only blobs(excluding reserved) and to only real data(excluding parity)

Originally posted by @Wondertan in #68 (comment)

@cmwaters
Copy link
Collaborator Author

I had a look and found that there already exists functions that cover this purpose, for example we have an IsReserved() method to check if it's part of the primary or secondary reserved namespaces. And I will add a IsUsableNamespace in #87

@cmwaters
Copy link
Collaborator Author

Closing this as completed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants