Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consider enabling go-critic #18

Closed
rootulp opened this issue Jan 11, 2024 · 2 comments · Fixed by #28
Closed

Consider enabling go-critic #18

rootulp opened this issue Jan 11, 2024 · 2 comments · Fixed by #28
Labels
good first issue Good for newcomers

Comments

@rootulp
Copy link
Collaborator

rootulp commented Jan 11, 2024

Context

celestiaorg/celestia-app#2987

Proposal

If go-critic is enabled in celestia-app, we may consider enabling it in this repo.
@rootulp rootulp added the good first issue Good for newcomers label Jan 11, 2024
@rootulp rootulp mentioned this issue Jan 11, 2024
Merged
@hoseincc

This comment was marked as spam.

Sign in to view
@rootulp
Copy link
Collaborator Author

rootulp commented Jan 23, 2024

celestiaorg/celestia-app#3000 was merged so we should do this here too.

@00x-dx 00x-dx mentioned this issue Jan 24, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore(linter): enable go-critic 00x-dx/go-square
2 participants
@rootulp @hoseincc