Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update nmt wrapper to accomodate new rsmt2d.Tree interface #255

Closed
evan-forbes opened this issue Mar 26, 2021 · 0 comments · Fixed by #256
Closed

Update nmt wrapper to accomodate new rsmt2d.Tree interface #255

evan-forbes opened this issue Mar 26, 2021 · 0 comments · Fixed by #256
Assignees
@evan-forbes

Comments

@evan-forbes
Copy link
Member

per this comment, we're moving forward with the new rsmt2d.Tree interface being defined in #20. Using this new interface, we need to make an nmt wrapper that works properly with extended data squares.

nmt wrapper ref: #238
must be completed before #235 can be finished
@evan-forbes evan-forbes self-assigned this Mar 26, 2021
@evan-forbes evan-forbes mentioned this issue Mar 26, 2021
Merged
cmwaters pushed a commit that referenced this issue Mar 13, 2023
@mergify @cason
0.34.x: Rename Tendermint to CometBFT: further actions (backport #224) (
b22a3a6 
#255)

* Rename Tendermint to CometBFT: further actions (#224)

* rename: Tendermint -> CometBFT in README files

* rename: Tendermint -> CometBFT in doc.go files

* rename: Tendermint -> CometBFT in Go documentation

* Removing unused/outdated CHANGELOGs

* rename: using CometBFT in issues and PR templates

* rename: references to tendermin in libs/events

* rename: renaming on text files under rpc/ dir

* rename: Tendermint-go -> CometBFT in proto docs

* rename: Tendermint -> CometBFT in generated go docs

* rename: renaming Tendermint -> CometBFT in scripts

* rename: renaming to CometBFT in code comments

* rename: general script files on repository root

* rename: using CometBFT in github config files

* rename: Go docs in .proto files, pb.go regenerated

* rename: toml config file generated content

* rename: avoiding unnecessary TM entries in comments

* rename: renaming in log messages and strings

* rename: upgrading instructions renamed, needs review

* rename: fixing generated protobuf files

* rename: fixing generated protobuf files

* rename: fixing broken test, renamed string

* Apply suggestions from code review

* Update .github/PULL_REQUEST_TEMPLATE.md

Co-authored-by: Thane Thomson <[email protected]>

* Update abci/README.md

Co-authored-by: Thane Thomson <[email protected]>

* Update proto/README.md

Co-authored-by: Thane Thomson <[email protected]>

* rename: removing unused files on repo root

---------

Co-authored-by: Daniel Cason <cason@gandria>
Co-authored-by: Thane Thomson <[email protected]>
(cherry picked from commit 1cb55d4)

# Conflicts:
#	.github/ISSUE_TEMPLATE/bug-report.md
#	.github/ISSUE_TEMPLATE/config.yml
#	.github/PULL_REQUEST_TEMPLATE.md
#	.github/issue_template.md
#	.github/workflows/janitor.yml
#	.github/workflows/lint.yml
#	.gitignore
#	.goreleaser.yml
#	UPGRADING.md
#	abci/README.md
#	abci/types/application.go
#	abci/types/mocks/base.go
#	cmd/cometbft/commands/version.go
#	config/config.go
#	config/toml.go
#	consensus/README.md
#	consensus/replay.go
#	consensus/replay_test.go
#	consensus/state.go
#	crypto/README.md
#	crypto/ed25519/ed25519.go
#	inspect/doc.go
#	inspect/inspect.go
#	internal/test/doc.go
#	libs/pubsub/query/query.go
#	libs/pubsub/query/syntax/doc.go
#	light/doc.go
#	networks/local/README.md
#	node/node.go
#	node/setup.go
#	p2p/README.md
#	proto/README.md
#	rpc/core/abci.go
#	rpc/core/blocks.go
#	rpc/core/consensus.go
#	rpc/core/doc.go
#	rpc/core/events.go
#	rpc/core/evidence.go
#	rpc/core/health.go
#	rpc/core/mempool.go
#	rpc/core/net.go
#	rpc/core/status.go
#	rpc/core/tx.go
#	rpc/jsonrpc/doc.go
#	rpc/openapi/openapi.yaml
#	scripts/metricsgen/metricsgen.go
#	test/fuzz/README.md
#	test/fuzz/oss-fuzz-build.sh
#	test/loadtime/cmd/load/main.go
#	tools/README.md
#	version/version.go

* rename: fixing cherry-pick conflicts

* rename: fixing cherry-pick conflicts

Co-authored-by:  Jasmina Malicevic <[email protected]>

* rename: fixing cherry-pick conflicts

Co-authored-by:  Jasmina Malicevic <[email protected]>

* rename: reverted changes on UPGRADING.md

* rename: Tendermint Core -> CometBFT on intro

* rename: further renaming Tendermint -> CometBFT

* rename: Tendermint -> CometBFT under test/maverick/

* rename: further renaming Tendermint -> CometBFT

* rename: removing copyright from internal package

* rename: Tendermint -> CometBFT in /spec/abci

* rename: further renaming Tendermint -> CometBFT

* rename: undoing renaming of jTendermint

* rename: removing reference to tendermint/go-amino

* rename: tendermint -> cometbft on .circleci/

---------

Co-authored-by: Daniel <[email protected]>
Co-authored-by: Jasmina Malicevic <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@evan-forbes evan-forbes

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

update the nmt wrapper to the new rsmt2d.Tree interface celestiaorg/celestia-core
1 participant
@evan-forbes