fix: correctly set app version in e2e genesis #3211
Conversation
…p into cal/knuu-metrics
cmwaters
requested review from
evan-forbes,
rootulp,
staheri14 and
ninabarbakadze
as code owners
|
CI tests is failing in new and interesting ways |
WalkthroughWalkthroughThe recent updates aim to enhance key management and genesis configuration in an end-to-end testing framework. Changes include replacing account keys with public keys, introducing a keyring for mnemonic generation, revising the genesis document creation process, and refining account and validator setup. These modifications streamline setup and configuration processes, improve security through better key management, and simplify the codebase by removing unused imports and updating import paths. Changes
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
| @@ -69,7 +69,7 @@ func TestE2ESimple(t *testing.T) { | |||
|
|
|||
| totalTxs := 0 | |||
| for _, block := range blockchain { | |||
| require.Equal(t, v1.Version, block.Version.App) | |||
| require.Equal(t, appconsts.LatestVersion, block.Version.App) | |||
There was a problem hiding this comment.
[no change needed] we can probably close #3201 if this PR merges
After modifying the default genesis params to use the latest, `TestMajorUpgradeToV2` began to fail because it required that the network first start at v1 and then upgrade to v2. This PR allows the app version at genesis to be set. This also does some refactoring by removing the duplicate genesis creation function i.e. `MakeGenesis` and instead imports the genesis test util package.
After modifying the default genesis params to use the latest,
TestMajorUpgradeToV2began to fail because it required that the network first start at v1 and then upgrade to v2. This PR allows the app version at genesis to be set.This also does some refactoring by removing the duplicate genesis creation function i.e.
MakeGenesisand instead imports the genesis test util package.