-
Notifications
You must be signed in to change notification settings - Fork 297
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: specs for multisig #2996
docs: specs for multisig #2996
Conversation
WalkthroughThe Celestia project has introduced native support for multisignature (multisig) accounts, allowing accounts to be controlled by multiple secret keys. This enhances security by adding a layer similar to two-factor authentication (2FA) but also increases the complexity of state transitions. The documentation has been updated to reflect this new feature, detailing the behavior, signature threshold, signers, and referencing the Cosmos SDK for implementation specifics. Changes
Assessment against linked issues
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! If possible, you might want to include a link to the script mentioned in the PR description within this doc.
Closes #736
Note: I played around with multisigs and wrote a script to show their basic functionality but that content seems more appropriate to live at https://docs.celestia.org/ than in the specs. Hence celestiaorg/docs#1351