chore(deps): replace old qgb contracts repo with blobstream repo #2709
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rach-id
added
dependencies
rach-id
requested review from
evan-forbes,
rootulp and
cmwaters
as code owners
Codecov Report
@@ Coverage Diff @@
## main #2709 +/- ##
=======================================
Coverage 19.89% 19.89%
=======================================
Files 139 139
Lines 16695 16695
=======================================
Hits 3322 3322
Misses 13051 13051
Partials 322 322
|
rach-id
added
the
backport:v1.x
rootulp
previously approved these changes
Oct 18, 2023
# Conflicts: # x/blobstream/client/verify.go
|
The rename PR will not be backported until we test it in an upgrade and be sure that it's not breaking. This one is clearly not breaking and would allow the new release to depend on the new renamed Blobstream contracts instead of depending on older version of QGB. Also, we will make new releases of Blobstream, so it makes sense to keep the v1.x up to date with latest Blobstream contracts |
evan-forbes
approved these changes
Oct 19, 2023
mergify bot
pushed a commit
that referenced
this pull request
Oct 19, 2023
<!-- Please read and fill out this form before submitting your PR. Please make sure you have reviewed our contributors guide before submitting your first PR. --> ## Overview The dependencies part of #2639 ## Checklist <!-- Please complete the checklist to ensure that the PR is ready to be reviewed. IMPORTANT: PRs should be left in Draft until the below checklist is completed. --> - [ ] New and updated code has appropriate documentation - [ ] New and updated code has new and/or updated testing - [ ] Required CI checks are passing - [ ] Visual proof for any user facing features like CLI or documentation updates - [ ] Linked issues closed with keywords (cherry picked from commit c517bd2) # Conflicts: # go.mod # x/qgb/client/verify.go
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
The dependencies part of #2639
Checklist