Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: describe need for GetModuleAccount #2215

Merged
merged 3 commits into from
Aug 7, 2023

Conversation

rootulp
Copy link
Collaborator

@rootulp rootulp commented Aug 5, 2023

Closes #2042

@rootulp rootulp added the documentation Improvements or additions to documentation label Aug 5, 2023
@rootulp rootulp added this to the Post-mainnet milestone Aug 5, 2023
@rootulp rootulp requested a review from rach-id August 5, 2023 19:23
@rootulp rootulp self-assigned this Aug 5, 2023
@MSevey MSevey requested a review from a team August 5, 2023 19:23
@codecov-commenter
Copy link

Codecov Report

Merging #2215 (a97b969) into main (0c55a6e) will increase coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #2215      +/-   ##
==========================================
+ Coverage   24.86%   24.87%   +0.01%     
==========================================
  Files         127      127              
  Lines       14326    14329       +3     
==========================================
+ Hits         3562     3565       +3     
  Misses      10397    10397              
  Partials      367      367              
Files Changed Coverage Δ
x/mint/keeper/genesis.go 80.00% <100.00%> (+5.00%) ⬆️

rach-id
rach-id previously approved these changes Aug 5, 2023
x/mint/keeper/genesis.go Outdated Show resolved Hide resolved
evan-forbes
evan-forbes previously approved these changes Aug 6, 2023
cmwaters
cmwaters previously approved these changes Aug 7, 2023
staheri14
staheri14 previously approved these changes Aug 7, 2023
@MSevey MSevey requested a review from a team August 7, 2023 13:08
@rootulp rootulp enabled auto-merge (squash) August 7, 2023 13:08
@rootulp rootulp merged commit 49da6b8 into celestiaorg:main Aug 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Document need for GetModuleAccount
6 participants