Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move v2 related constants to v2 directory #3035

Closed
ninabarbakadze opened this issue Jan 23, 2024 · 0 comments
Closed

move v2 related constants to v2 directory #3035

ninabarbakadze opened this issue Jan 23, 2024 · 0 comments
Assignees

Comments

@ninabarbakadze
Copy link
Member

ninabarbakadze commented Jan 23, 2024

Summery

          [blocking][question] for @cmwaters. The breakdown of files in `pkg/appconsts` has me wondering where this constant should be defined. Candidates:
  1. consensus_consts.go because this is a new "consensus constant"
  2. v2/app_consts.go because this is a new param introduced in app version v2

If we do keep this in initial_consts.go then I think we need to update the comment at the top of this file because this constant can't be modified via on-chain governance or the node's local config.

// The following defaults correspond to initial parameters of the network that can be changed, not via app versions
// but other means such as on-chain governance, or the nodes local config

Originally posted by @rootulp in #2985 (comment)

@ninabarbakadze ninabarbakadze self-assigned this Jan 23, 2024
ninabarbakadze added a commit that referenced this issue Jan 24, 2024
## Overview

moving GlobalMinGasPrice constant under v2

Fixes - #3035

---------

Co-authored-by: Rootul P <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant