From f319b1582b8b13e279a2a62bcd7e1567f078de11 Mon Sep 17 00:00:00 2001 From: Rootul P Date: Mon, 9 Oct 2023 07:55:10 -0400 Subject: [PATCH] chore: reduce VotingPeriod to 1 week (#2627) Closes https://github.com/celestiaorg/celestia-app/issues/2625 (cherry picked from commit 8e62d4474b20783d5890e0316f6e5e5bd6d79ff6) --- app/default_overrides.go | 3 +-- app/default_overrides_test.go | 3 +-- specs/src/specs/params.md | 2 +- 3 files changed, 3 insertions(+), 5 deletions(-) diff --git a/app/default_overrides.go b/app/default_overrides.go index dfc065e1c4..c2a9d6f199 100644 --- a/app/default_overrides.go +++ b/app/default_overrides.go @@ -160,11 +160,10 @@ func (govModule) DefaultGenesis(cdc codec.JSONCodec) json.RawMessage { genState := govtypes.DefaultGenesisState() day := time.Duration(time.Hour * 24) oneWeek := day * 7 - twoWeeks := oneWeek * 2 genState.DepositParams.MinDeposit = sdk.NewCoins(sdk.NewCoin(BondDenom, sdk.NewInt(1_000_000_000))) // 1000 TIA genState.DepositParams.MaxDepositPeriod = &oneWeek - genState.VotingParams.VotingPeriod = &twoWeeks + genState.VotingParams.VotingPeriod = &oneWeek return cdc.MustMarshalJSON(genState) } diff --git a/app/default_overrides_test.go b/app/default_overrides_test.go index ec9e155a28..314a78d8cf 100644 --- a/app/default_overrides_test.go +++ b/app/default_overrides_test.go @@ -16,7 +16,6 @@ func Test_newGovModule(t *testing.T) { encCfg := encoding.MakeConfig(ModuleEncodingRegisters...) day := time.Duration(time.Hour * 24) oneWeek := day * 7 - twoWeeks := oneWeek * 2 govModule := newGovModule() raw := govModule.DefaultGenesis(encCfg.Codec) @@ -31,5 +30,5 @@ func Test_newGovModule(t *testing.T) { assert.Equal(t, want, govGenesisState.DepositParams.MinDeposit) assert.Equal(t, oneWeek, *govGenesisState.DepositParams.MaxDepositPeriod) - assert.Equal(t, twoWeeks, *govGenesisState.VotingParams.VotingPeriod) + assert.Equal(t, oneWeek, *govGenesisState.VotingParams.VotingPeriod) } diff --git a/specs/src/specs/params.md b/specs/src/specs/params.md index 71fc28d0ea..f8c5cb9b20 100644 --- a/specs/src/specs/params.md +++ b/specs/src/specs/params.md @@ -33,7 +33,7 @@ are blocked by the `x/paramfilter` module. | distribution.BonusProposerReward | 0 | Extra reward in the mint denomination for proposers based on the voting power included in the commit. | True | | gov.DepositParams.MinDeposit | 1000000000utia (1000 TIA) | Minimum deposit for a proposal to enter voting period. | True | | gov.DepositParams.MaxDepositPeriod | 1209600000000000 (1 week) | Maximum period for token holders to deposit on a proposal in nanoseconds. | True | -| gov.VotingParams.VotingPeriod | 604800000000000 (2 weeks) | Duration of the voting period in nanoseconds. | True | +| gov.VotingParams.VotingPeriod | 604800000000000 (1 week) | Duration of the voting period in nanoseconds. | True | | gov.TallyParams.Quorum | 0.334 (33.4%) | Minimum percentage of total stake needed to vote for a result to be considered valid. | True | | gov.TallyParams.Threshold | 0.50 (50%) | Minimum proportion of Yes votes for proposal to pass. | True | | gov.TallyParams.VetoThreshold | 0.334 (33.4%) | Minimum value of Veto votes to Total votes ratio for proposal to be vetoed. | True |