You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Yes this can be more subtle that one expects as well. Specifying an invalid cachepath causes it to default back if you are running multiple instances this is going to run into the singleton problem which if you have the handler for you might catch quickly but if not the crash may not be apparent.
I think the easiest decently bulletproof way to do this is something along the lines of:
if(!String.IsNullOrWhitespace(CachePath)){vardi=DirectoryInfo(CachePath);if(Path.GetRelativePath(di.FullPath,RootCachePath)!="."&&Path.GetRelativePath(di.Parent.FullPath,RootCachePath)!=".")thrownewArgumentException("If specifying CachePath it must be equal to the RootCachePath or a direct child directory of it");}
(That is code from my poor memory so almost certainly won't compile but the gyst:)
Granted GetRelativePath is .net std 2.1 so doesn't help most .net framework users. Pretty sure there is GetFinalPath or getfinaltarget or something as well but i think that is an even newer .net version.
One could pinvoke with GetFinalPathNameByHandle but that might be overkill. Could just force users to not use tricky naming so CachePath.Parent must directly equal rootcachepath or throw an error (as cef probably is using basic logic to determine if it should allow the cachepath without full resolution like the above).
I think the easiest decently bulletproof way to do this is something along the lines of:
(That is code from my poor memory so almost certainly won't compile but the gyst:)
Granted GetRelativePath is .net std 2.1 so doesn't help most .net framework users. Pretty sure there is GetFinalPath or getfinaltarget or something as well but i think that is an even newer .net version.
One could pinvoke with GetFinalPathNameByHandle but that might be overkill. Could just force users to not use tricky naming so CachePath.Parent must directly equal rootcachepath or throw an error (as cef probably is using basic logic to determine if it should allow the cachepath without full resolution like the above).
Originally posted by @mitchcapper in #4925 (comment)
The text was updated successfully, but these errors were encountered: