Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

No overtime / penalty shootouts...? #35

Open
E-VANCE opened this issue Jul 2, 2018 · 2 comments
Open

No overtime / penalty shootouts...? #35

E-VANCE opened this issue Jul 2, 2018 · 2 comments
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@E-VANCE
Copy link

E-VANCE commented Jul 2, 2018

Great app, much appreciated!

Just wondering: Overtime / penalty shootouts are not supported, right...?
@GAumala
Copy link
Contributor

GAumala commented Jul 2, 2018

Unfortunately, that's not supported yet. The data is already there, though
screenshot from 2018-07-02 11-39-24

The home_team and away_team objects of the match JSON object have a penalties number with the score of the penalty shootout. We just need to change the UI to display this extra information, but I'm not sure exactly how.

@cedricblondeau cedricblondeau added the enhancement New feature or request label Jul 3, 2018
@cedricblondeau
Copy link
Owner

cedricblondeau commented Jul 3, 2018 •
edited
Loading

It would be great to add them.
I'm not sure where they could fit in the MatchDetails component tho 🤔.

@cedricblondeau cedricblondeau added help wanted Extra attention is needed and removed help wanted Extra attention is needed labels Jul 3, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@cedricblondeau @E-VANCE @GAumala