Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add cedar-go to the benchmarks #115

Open
2 tasks
cdisselkoen opened this issue Mar 28, 2024 · 4 comments
Open
2 tasks

Add cedar-go to the benchmarks #115

cdisselkoen opened this issue Mar 28, 2024 · 4 comments
Labels
feature-request Request for a new feature

Comments

@cdisselkoen
Copy link
Contributor

Category

oopsla-2024-benchmarks

Describe the expansion you'd like to request

The benchmarks in the oopsla2024-benchmarks directory currently only compare the main Cedar implementation (in Rust). We should also compare the Cedar Go implementation at cedar-policy/cedar-go.

Additional context

No response

Is this something that you'd be interested in working on?

  • 👋 I may be able to implement this feature request
  • ⚠️ This feature might incur a breaking change
@cdisselkoen cdisselkoen added feature-request Request for a new feature pending-triage Hasn't been triaged yet labels Mar 28, 2024
@john-h-kastner-aws john-h-kastner-aws added backlog and removed pending-triage Hasn't been triaged yet labels Apr 1, 2024
@jmccarthy
Copy link

Started work on this. Regarding the Go engine wrapper:

  • Any reason I shouldn't generalize oopsla2024-benchmarks/tinytodo/rego/cmd/tinytodo/main.go into a "Go runner", giving it the ability to execute Rego and cedar-go?
  • Any downsides to also giving it a generic name vs tinytodo? (GO_BINARY_PATH="tinytodo" but it actually processes github and gdrive apps as well)

@cdisselkoen
Copy link
Contributor Author

Both of these sound like excellent plans to me

@philhassey
Copy link

Does completing this issue create a cedar-go-hello-world as a by-product, or should that be added as a separate issue?

@cdisselkoen
Copy link
Contributor Author

Up to you, but to me it seems probably separable

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature-request Request for a new feature
Projects
None yet
Development

No branches or pull requests

4 participants