Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes aimed at fixing msys builds. #77

Open
wants to merge 31 commits into
base: master
Choose a base branch
from
Open

Conversation

Bekenn
Copy link
Contributor

@Bekenn Bekenn commented Aug 10, 2015

No description provided.

@Bekenn
Copy link
Contributor Author

Bekenn commented Aug 10, 2015

These changes are aimed at fixing msys builds, so far just covering getting configure to work properly.

This allows configure to work properly on msys2/mingw-w64.
… C++11 support, don't support that option anyway.
Don't build cdenable sources for 64-bit.
Use CreateThread instead of _beginthreadex.
Replaced _beginthreadex with CreateThread.
No longer need to support VC6, so don't avoid including files everyone has these days.
Added disambiguating parentheses to silence Clang warnings.
More K&R begone.
Some warning fixes.
Add macro to make mingw headers behave more like MS headers with respect to time_t.
…don't know how else toput it in C++11 mode.

Link to Winsock2.
Don't try to link CrossPlatform files twice.
Size check is now a static_assert (detected at compile time instead of run time).
…rge number of casts.

Tweaked various types in function signatures to reduce casts and improve const correctness.
Fixed lots of related warnings.
@Bekenn
Copy link
Contributor Author

Bekenn commented Aug 21, 2015

BasiliskII now compiles and runs (with JIT!) using msys2 and clang. MSVC still works, though I should write up instructions on how to set it up properly...

@cat7
Copy link

cat7 commented Aug 22, 2015

Hi, please do write those instructions so we can update the compiling guide at http://www.emaculation.com/doku.php/compiling_sheepshaver_basilisk
Btw: does SheepShaver for Windows still compile the old way?

@Bekenn
Copy link
Contributor Author

Bekenn commented Aug 23, 2015

SheepShaver is almost certainly broken and will require some attention; that's the next thing I plan to focus on.

@asvitkine
Copy link
Collaborator

Any progress since your last comment? I don't want to merge a pull request that breaks SheepShaver or breaks compatibility with the previous compilation process.

@Bekenn
Copy link
Contributor Author

Bekenn commented Dec 29, 2015

I owe you a massive apology; I've been focusing on other projects. Cancel
the pull request for now; hopefully I'll get back to it later.

On Tue, Dec 29, 2015 at 8:57 AM, asvitkine [email protected] wrote:

Any progress since your last comment? I don't want to merge a pull request
that breaks SheepShaver or breaks compatibility with the previous
compilation process.


Reply to this email directly or view it on GitHub
#77 (comment).

@asvitkine
Copy link
Collaborator

No worries.

On Tue, Dec 29, 2015 at 1:50 PM, Bekenn [email protected] wrote:

I owe you a massive apology; I've been focusing on other projects. Cancel
the pull request for now; hopefully I'll get back to it later.

On Tue, Dec 29, 2015 at 8:57 AM, asvitkine [email protected]
wrote:

Any progress since your last comment? I don't want to merge a pull
request
that breaks SheepShaver or breaks compatibility with the previous
compilation process.


Reply to this email directly or view it on GitHub
#77 (comment).


Reply to this email directly or view it on GitHub
#77 (comment).

@Bekenn
Copy link
Contributor Author

Bekenn commented Nov 1, 2017

Clearly I haven't been focusing on this; I have no current plans to return to it. Sorry!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants