diff --git a/.github/workflows/upgrade-node.yml b/.github/workflows/upgrade-node.yml index 4dd4f1a..1c32341 100644 --- a/.github/workflows/upgrade-node.yml +++ b/.github/workflows/upgrade-node.yml @@ -34,10 +34,9 @@ jobs: - name: Update the package with the new minimum Node version and update @types/node if: env.CURRENT_NODEJS_VERSION_SHORT != env.NEW_NODEJS_VERSION_SHORT run: |- - # This currently doesn't work because of a conflict between npm and yarn workspaces: - # npm pkg set engines.node=">= $NEW_NODEJS_VERSION" - # The below workaround is a bit of a hack that can hopefully be removed soon - sed -i "s/$CURRENT_NODEJS_VERSION/$NEW_NODEJS_VERSION/" ./package.json + npm pkg set engines.node=">= $NEW_NODEJS_VERSION" + # Use the below hacky workaround if npm and yarn workspaces still conflict for future updates + # sed -i "s/$CURRENT_NODEJS_VERSION/$NEW_NODEJS_VERSION/" ./package.json yarn add -W -D @types/node@^$NEW_NODEJS_VERSION_SHORT # If there are other steps you need to take in your project to update Node.js everywhere, add those here - name: Get values for pull request