chore: upgrade jsii rosetta dependency #1646
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When using NodeJS version managers like [nvm](https://github.com/nvm-sh/nvm) or [fnm](https://github.com/Schniz/fnm), the NodeJS binary location can be a bit "funny". For example on macOS with fnm, the NodeJS binary path may contain folder `Application Support` which has a space in it. Wrapping the process.execPath interpolated value into quotes solves this.
|
Note: There was several warnings from JSII during warning JSII6: A "peerDependency" on "@aws-cdk/aws-s3" at "^1.110.1" means you should take a "devDependency" on "@aws-cdk/aws-s3" at "1.110.1" (found "undefined")
warning JSII6: A "peerDependency" on "@aws-cdk/core" at "^1.110.1" means you should take a "devDependency" on "@aws-cdk/core" at "1.110.1" (found "undefined")
lib/index.ts:3:1 - warning JSII5: The type "constructs.Construct" is exposed in the public API of this module. Therefore, the module "constructs" must also be defined under "peerDependencies". This will be auto-corrected unless --no-fix-peer-dependencies was specified.
3 export class GreeterBucket extends s3.Bucket {
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
4
...
11 }
~~~
12 }
~
lib/submod1/index.ts:3:1 - warning JSII5: The type "constructs.Construct" is exposed in the public API of this module. Therefore, the module "constructs" must also be defined under "peerDependencies". This will be auto-corrected unless --no-fix-peer-dependencies was specified.
3 export class GoodbyeBucket extends s3.Bucket {
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
4
...
11 }
~~~
12 }
~So they seem to be the just the state of things in the main branch too. |
|
@aripalo once conflicts are resolved we can merge this. thanks! |
auto-merge was automatically disabled
December 9, 2024 07:53
Pull request was closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1643
This PR is built on top of PR #1645 (which was a requirement for me to get the cli.test.ts to pass). So before merging this, makes sense to merge #1645 (and so close #1644).