Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doesn't work with radon 6.0.1 #5

Open
Sterh20 opened this issue Jun 6, 2023 · 6 comments
Open

Doesn't work with radon 6.0.1 #5

Sterh20 opened this issue Jun 6, 2023 · 6 comments

Comments

@Sterh20
Copy link

Sterh20 commented Jun 6, 2023

Tried to use the extension with the latest radon package (6.0.1), but the extension kept spamming

"You need to install python-radon at a minimum version 5.1: pip install "radon>=5.1"

Also cyclomatic complexity wasn't showing in the .py files.

After installing radon version 5.1 the issue resolved itself.


Windows 10 Pro 10.0.19045
VS Code 1.78.2
Python 3.10.11

@Viktini
Copy link

Viktini commented Jun 21, 2023

Managed to reproduce this on Windows 11, Python 3.11.4, VS Code 1.78.2. Installing 5.1 fixes the issue.

@Drache91
Copy link
Contributor

I suppose it is this line causing the version check confusion:

if (major < 5 || minor < 1) {

            if (major < 5 || minor < 1) {
                throw new UnsupportedVersionException("You need at least python radon version 5.1 installed. Try pip install \"radon>=5.1\".");
            }

Should fix itself with a radon version that has the minor version >= 1. But I think the version check should be fixed.

Drache91 added a commit to Drache91/python-radon that referenced this issue Jul 27, 2023
Fix for Issue cdein#5 

Fix version check to allow major versions higher than 5 and with minor versions lower than 1 (like 6.0.1)
@DerekCL
Copy link

DerekCL commented Feb 19, 2024

Still, an issue as of today since the fix was merged in July of 2023( as you can see from above) but the last released in the vs code store was:

Last released
2022-02-28, 15:15:22

@dylan-robins
Copy link

Still facing this issue today. @cdein, any plans on releasing the fix on the vscode marketplace any time soon? I'd like to promote the use of this in my company as it's a really useful tool...

@nickweedon
Copy link

I too would like to see this released. In the meantime you can actually create a simple wrapper script to intercept a call to the binary with the '-v' argument and then perform a proper check and just return 5.2 if the version really is >=5.1.

@igoutta
Copy link

igoutta commented Sep 19, 2024

Still doesn't work. Getting into vscode-radon-linter.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

7 participants