Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Fix ancillary handling in ZX checker #512

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

burgholzer
Copy link
Member

Description

Fixes #508

This PR updates MQT Core with the fix from cda-tum/mqt-core#758.

Unfortunately, this does not yet fully address the underlying issue in the ZX checkers capabilities of handling ancillaries. See the regression tests and the corresponding CI failures:

  • the first C++ test, which previously segfaulted, now returns equivalent, while all other checkers agree that the two circuits are not equivalent.
  • the second C++ test is a full C++ reproducer of the failing Python test. This test segfaults due to a map out of range error.
  • the Python test is adapted from 🐛 Partial equivalence with ancillary qubits #508

Note the first two tests fail for separate reasons, which means there are multiple things going wrong here.

Checklist:

  • The pull request only contains commits that are related to it.
  • I have added appropriate tests and documentation.
  • I have made sure that all CI jobs on GitHub pass.
  • The pull request introduces no new warnings and follows the project's style guidelines.

@burgholzer burgholzer added c++ Anything related to C++ code fix Anything related to bugfixes labels Nov 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c++ Anything related to C++ code fix Anything related to bugfixes
Projects
Status: In Progress
Status: In Progress
Development

Successfully merging this pull request may close these issues.

🐛 Partial equivalence with ancillary qubits
1 participant