-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Approximate equivalence checking #443
Open
TeWas
wants to merge
44
commits into
cda-tum:main
Choose a base branch
from
TeWas:approximate-equivalence-checking
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
burgholzer
added
feature
New feature or request
c++
Anything related to C++ code
labels
Aug 13, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #443 +/- ##
=======================================
+ Coverage 95.3% 95.4% +0.1%
=======================================
Files 40 42 +2
Lines 1835 2057 +222
Branches 224 261 +37
=======================================
+ Hits 1749 1964 +215
- Misses 86 93 +7
|
… simulateSlicing, reverse iterate through second circuit in simulateSlicing
…cisions const; add failing tests
- Invert qc2 only once and not in each decision iteration
- Handle HSF-related errors in the EquivalenceCheckingManager via DDHybridSchrodingerFeynmanChecker::canHandle - Refactor HSF to inherit from EquivalenceChecker instead of DDEquivalenceChecker and avoid redundant initializations - Disable optimizations for the HSF checker
… checking setting
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Introducing approximate equivalence checking by computing the Frobenius inner product between 𝑈 and 𝑉 and comparing the result to a predefined threshold. This enhancement allows for a more flexible comparison that accounts for near-equivalent circuits. The
DDAlternatingChecker
andDDEquivalenceChecker
have been adapted to incorporate this approach.Additionally, the
HybridSchrodingerFeynmanChecker
has been added. The checker divides a circuit horizontally into two halves: a lower part and an upper part. This is achieved by cutting controlled gates that cross the middle line according to the Schmidt decomposition.By leveraging key trace equalities - specifically,
we can treat the lower and upper circuit parts, as well as the summands from the Schmidt decomposition, independently. This enables parallel trace computation, allowing to check the equivalence of larger, yet shallow circuits.
Fixes #442
Checklist: