Skip to content

Commit

Permalink
fix: move gRPC dependencies to an extra
Browse files Browse the repository at this point in the history
PR feast-dev#3687 added a spiffy feature to ingest streaming features, but this
came along with a large batch of depdencies.  Notable this induces a
core dependency on `protobuf>=4.21.6` while Feast itself is on
`protobuf<4.23.4,>3.20`.  This is a fiddly narrow range and excludes
all 3.x uses.

Signed-off-by: Chris Burroughs <[email protected]>
  • Loading branch information
cburroughs committed Jan 24, 2024
1 parent 86d6221 commit 0ae2ffe
Showing 1 changed file with 10 additions and 4 deletions.
14 changes: 10 additions & 4 deletions setup.py
Original file line number Diff line number Diff line change
Expand Up @@ -45,10 +45,6 @@
"colorama>=0.3.9,<1",
"dill~=0.3.0",
"fastavro>=1.1.0,<2",
"grpcio>=1.56.2,<2",
"grpcio-tools>=1.56.2,<2",
"grpcio-reflection>=1.56.2,<2",
"grpcio-health-checking>=1.56.2,<2",
"mypy-protobuf==3.1",
"Jinja2>=2,<4",
"jsonschema",
Expand Down Expand Up @@ -144,6 +140,14 @@
"hazelcast-python-client>=5.1",
]


GRPCIO_REQUIRED = [
"grpcio>=1.56.2,<2",
"grpcio-tools>=1.56.2,<2",
"grpcio-reflection>=1.56.2,<2",
"grpcio-health-checking>=1.56.2,<2",
]

CI_REQUIRED = (
[
"build",
Expand Down Expand Up @@ -202,6 +206,7 @@
+ AZURE_REQUIRED
+ ROCKSET_REQUIRED
+ HAZELCAST_REQUIRED
+ GRPCIO_REQUIRED
)


Expand Down Expand Up @@ -368,6 +373,7 @@ def run(self):
"docs": DOCS_REQUIRED,
"cassandra": CASSANDRA_REQUIRED,
"hazelcast": HAZELCAST_REQUIRED,
"grpcio": GRPCIO_REQUIRED,
"rockset": ROCKSET_REQUIRED,
},
include_package_data=True,
Expand Down

0 comments on commit 0ae2ffe

Please sign in to comment.