You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
yarn test --silent --updateSnapshot --runInBand --no-watchman --testPathPattern="/Board|Communicator|App|Settings|Account|UI/"
which is updating the snapshots as part of the test process. Meaning that the snapshot testing is always forced to pass.
I ran those tests in master branch and it's updating two snapshots:
➜ cboard git:(master) ✗ gst
On branch master
Your branch is up to date with 'origin/master'.
Changes not staged for commit:
(use "git add <file>..." to update what will be committed)
(use "git restore <file>..." to discard changes in working directory)
modified: src/components/Communicator/CommunicatorDialog/__snapshots__/CommunicatorDialog.test.js.snap
modified: src/components/Settings/Navigation/__snapshots__/Navigation.test.js.snap
Should we remove all snapshot tests?
or
Update circle CI and current snapshots?
The text was updated successfully, but these errors were encountered:
I don't have a preference for using snapshot tests or not. If we already have UI automation in place, I don't see much value in these tests unless we check on other special HTML attributes (like aria-*). But I'd like to hear y'all comments on this.
circle CI is running this:
which is updating the snapshots as part of the test process. Meaning that the snapshot testing is always forced to pass.
I ran those tests in master branch and it's updating two snapshots:
or
The text was updated successfully, but these errors were encountered: