Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Snapshot tests aren't being used #1656

Open
maxicapodacqua opened this issue Dec 29, 2023 · 1 comment
Open

Snapshot tests aren't being used #1656

maxicapodacqua opened this issue Dec 29, 2023 · 1 comment

Comments

@maxicapodacqua
Copy link
Contributor

circle CI is running this:

yarn test --silent --updateSnapshot --runInBand --no-watchman --testPathPattern="/Board|Communicator|App|Settings|Account|UI/"

which is updating the snapshots as part of the test process. Meaning that the snapshot testing is always forced to pass.

I ran those tests in master branch and it's updating two snapshots:

➜  cboard git:(master) ✗ gst
On branch master
Your branch is up to date with 'origin/master'.

Changes not staged for commit:
  (use "git add <file>..." to update what will be committed)
  (use "git restore <file>..." to discard changes in working directory)
        modified:   src/components/Communicator/CommunicatorDialog/__snapshots__/CommunicatorDialog.test.js.snap
        modified:   src/components/Settings/Navigation/__snapshots__/Navigation.test.js.snap
  • Should we remove all snapshot tests?
    or
  • Update circle CI and current snapshots?
@maxicapodacqua
Copy link
Contributor Author

I don't have a preference for using snapshot tests or not. If we already have UI automation in place, I don't see much value in these tests unless we check on other special HTML attributes (like aria-*). But I'd like to hear y'all comments on this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant