-
Notifications
You must be signed in to change notification settings - Fork 334
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BUG] FuzzyMap.IKey is package private #505
Comments
I spent some time integrating jcommander and unit testing it. When I went to build the application package, I also came across this error. Since it is a simple fix, can I submit a PR and have this included in the 1.84 release? |
It would be nice if someone could post a complete and comprehensible problem description. FuzzyMap is not intended to be part of the public API. We should replace it in the API by etc. Object. |
While IKey may not be intended to be part of the public API, it is currently made public in the method on class JCommander:
While the best solution might be to change the interface on JCommander so as not to expose IKey, the quick option is to make IKey public
Since this method is broken anyway, so no one could be using it, perhaps there is no harm in changing the interface to not expose IKey. |
We should go with that one. |
jcommander-1.78
The text was updated successfully, but these errors were encountered: