Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

If an external function clashes with a function in global env should it replace it? #200

Open
cbaggers opened this issue May 27, 2018 · 0 comments
Assignees

Comments

@cbaggers
Copy link
Owner

The following code foo is defined but the existing func from global is still used (returning a foo-g object)

(add-external-function 'foo '() '()
                       '(1))

(defun test2 ()
  (glsl-code
   (translate
    (create-stage
     :vertex :450
     :code '((let ((x (foo)))
               (+ x 10)
               (vec4 1)))))))
Varjo: There is no applicable method for the glsl function '+'
when called with argument types:
(FOO :INT32)

Form: (+ X 10)
   [Condition of type VARJO-CONDITIONS:NO-VALID-FUNCTION]

This issues hits on some deeper issues for example, what if its a function from the glsl spec? Amybe in that specific case we should not allow replacement, simply because it fucks things up for other users

@cbaggers cbaggers self-assigned this May 27, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant