Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix write of Symlink files #16

Closed
wants to merge 2 commits into from
Closed

Fix write of Symlink files #16

wants to merge 2 commits into from

Conversation

antoineco
Copy link

@antoineco antoineco commented Sep 29, 2023 •
edited
Loading

Fixes #15

writeSVR4Header() currently omits the following for files with mode Symlink:

  • The file's Size must match the link target (Linkname)
  • The link target must be written after the pad that follows the file's name

Both match the way readSVR4Header() translates the final read into a Linkname (and returned file size of 0).

@antoineco antoineco marked this pull request as ready for review September 29, 2023 16:24
@antoineco antoineco mentioned this pull request Sep 29, 2023
Closed
4 tasks
@antoineco antoineco closed this by deleting the head repository Oct 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Files of type Symlink are not written correctly
1 participant
@antoineco