-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat/ecoinvent interface #16
Conversation
also cleanup the login signal and move them out of the downloader
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, I am impressed that you saw some basic patterns have changed.
In the future I am pretty sure we can remove ABEcoinventDownloader
completely.
One last change needed (building on LCA-ActivityBrowser#1301): The current code assumes that a database called "biosphere3" is present, but this is an antipattern. Instead, we should set the default biosphere preference to the biosphere database corresponding to the ecoinvent import. So, if we imported ecoinvent 3.9.1, we would end up with two databases: ecoinvent-3.9.1-something
and ecoinvent-3.9.1-biosphere
. We need to run the following:
import bw2data as bd
bd.preferences['biosphere_database'] = 'ecoinvent-3.9.1-biosphere'
bd.preferences.flush()
going back and forth between the wizard pages can set this to an empty string and cause an exception
Added the bd.preferences to update on eco version page. |
No. In general this isn't a great idea, and should require manual action by the user after the import complete. |
still have a fallback if the provided file is 7z
b031a1c
to
7d09448
Compare
I ended having to integrate UpdateBiosphere for the newly versioned database created. Otherwise the end user will go through the flow of trying to import the database, only to get the This versioned database page only gets shown to the end user if that particular database does not exist already. |
7d09448
to
a7d87e1
Compare
ecoinvent_interface
package instead ofeidl
.biosphere
Closes #7
Checklist
bug
,feature
,ui
,change
,documentation
,breaking
,ci
as they show up in the changelog.