Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(go): fix go icons when go plugin is installed #158

Merged
merged 1 commit into from
Dec 6, 2024
Merged

Conversation

thelooter
Copy link
Collaborator

@thelooter thelooter commented Dec 1, 2024

This PR fixes the Go Icon when the Go Core Plugin is installed (e.g. in Goland). This fixes #97

@thelooter thelooter added the bug Something isn't working label Dec 1, 2024
@thelooter thelooter self-assigned this Dec 1, 2024
@sgoudham
Copy link
Contributor

sgoudham commented Dec 3, 2024

@quentinguidee can you confirm that the artifact built from the PR works for you?

@quentinguidee
Copy link
Member

Looks good to me!

image

Copy link
Contributor

@sgoudham sgoudham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not a Kotlin programmer so I can't speak to code quality but its understandable on a general level so looks fine to me.

@thelooter thelooter merged commit d94d3ec into main Dec 6, 2024
1 check passed
@thelooter thelooter deleted the fix/go-icons branch December 6, 2024 19:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Golang *_test.go files support
3 participants