Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

using different icons for different type of java files #8

Closed
dragove opened this issue Nov 2, 2023 · 6 comments · Fixed by #35
Closed

using different icons for different type of java files #8

dragove opened this issue Nov 2, 2023 · 6 comments · Fixed by #35
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@dragove
Copy link

dragove commented Nov 2, 2023

It's simple to know if a java file is a class, an interface or an abstract class when using default icons. When using this icon set, they are all the same.

@quentinguidee quentinguidee added the enhancement New feature or request label Nov 2, 2023
@Desoroxxx
Copy link

Very interested in this icon pack, but this makes it unusable for me, hope they can be added soon!

@azdanov
Copy link

azdanov commented Jan 1, 2024

Would it be possible to have an option checkbox to use the default icons for Java when using this icon set?

As an example, the Atom Material Icons has an option like that:
Screenshot 2024-01-01 at 09 25 31

@quentinguidee
Copy link
Member

PR opened for the implementation (#28)

Will be merged soon (when the icons will be designed)

@sgoudham
Copy link
Contributor

New icons were designed and shipped as part of vscode-icons v1.12.0 which should allow #28 to proceed.

However, @quentinguidee and I are pretty busy at the moment so we'd very much appreciate help in updating the PR to assign the new icons 👍

@sgoudham sgoudham added the help wanted Extra attention is needed label May 10, 2024
@quentinguidee
Copy link
Member

Also, feel free to recreate the PR with a different method, I'm not sure if depending on each plugins is the right way to go!

@sgoudham
Copy link
Contributor

Hi 👋

We've added different coloured icons as part of #35 which are shown below:

image

I've raised an issue on vscode-icons: catppuccin/vscode-icons#161 to hopefully try and rework the icons to be differentiated in terms of shape too 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants