Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IAM role check doesn't catch all potential exceptions #38

Open
golenkovm opened this issue Oct 1, 2020 · 0 comments
Open

IAM role check doesn't catch all potential exceptions #38

golenkovm opened this issue Oct 1, 2020 · 0 comments

Comments

@golenkovm
Copy link
Contributor

golenkovm commented Oct 1, 2020 •
edited
Loading

When IAM role is not set it tries to connect without key and secreat and therefore throws \Aws\Exception\CredentialsException exception:
https://github.com/catalyst/moodle-fileconverter_librelambda/blob/master/classes/converter.php#L202-L206
Therefore the setting page is not displayed at all:
image

See objectfs as an example:
https://github.com/catalyst/moodle-tool_objectfs/blob/master/classes/local/store/s3/client.php#L215-L234

Also as part of IAM role change this line was changed:
c68fe43#diff-b9a34794852807cf1a15b1525ad6e3dbR106
Thus, proxy is used even when the setting is set to 0.

And the last one:
This return isn't expected. Should be bool
https://github.com/catalyst/moodle-fileconverter_librelambda/blob/master/classes/converter.php#L323
hdagheda added a commit to hdagheda/moodle-fileconverter_librelambda that referenced this issue Oct 5, 2020
@hdagheda
Issue catalyst#38: 1. Add extra exceptions
47a1963
hdagheda added a commit to hdagheda/moodle-fileconverter_librelambda that referenced this issue Oct 5, 2020
@hdagheda
Issue catalyst#38: 2. Revert proxy check
d4daab4
hdagheda added a commit to hdagheda/moodle-fileconverter_librelambda that referenced this issue Oct 5, 2020
@hdagheda
Issue catalyst#38: 3. Return bool only from are_requirements_met func…
6453619 
…tion
hdagheda added a commit to hdagheda/moodle-fileconverter_librelambda that referenced this issue Oct 5, 2020
@hdagheda
Issue catalyst#38: 3. Return bool only from are_requirements_met func…
b971dfb 
…tion
hdagheda added a commit to hdagheda/moodle-fileconverter_librelambda that referenced this issue Oct 6, 2020
@hdagheda
Issue catalyst#38: 3. Return bool only from are_requirements_met func…
c31c89f 
…tion
@golenkovm golenkovm mentioned this issue Oct 6, 2020
Merged
hdagheda added a commit to hdagheda/moodle-fileconverter_librelambda that referenced this issue Oct 7, 2020
@hdagheda
Issue catalyst#38: improvement to static functions
fe1e0a2
hdagheda added a commit to hdagheda/moodle-fileconverter_librelambda that referenced this issue Oct 7, 2020
@hdagheda
Issue catalyst#38: improvement to static functions and fix tests
0cc5888
hdagheda added a commit to hdagheda/moodle-fileconverter_librelambda that referenced this issue Oct 12, 2020
@hdagheda
Issue catalyst#38: improvement to static functions and fix tests
f426ce9
hdagheda added a commit to hdagheda/moodle-fileconverter_librelambda that referenced this issue Oct 14, 2020
@hdagheda
Issue catalyst#38: improvement to static functions and fix tests
10de799
hdagheda added a commit to hdagheda/moodle-fileconverter_librelambda that referenced this issue Oct 14, 2020
@hdagheda
Issue catalyst#38: improvement to static functions and fix tests
33b2551
hdagheda added a commit to hdagheda/moodle-fileconverter_librelambda that referenced this issue Oct 15, 2020
@hdagheda
Issue catalyst#38: improvement to static functions and fix tests
907e77b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@golenkovm