Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix test app #2310

Open
wants to merge 4 commits into
base: trunk
Choose a base branch
from
Open

Fix test app #2310

wants to merge 4 commits into from

Conversation

AntonButov
Copy link

TestApp is broken. I think it's because of this issue. I fixed it by changing UInt to Int for the color in TestApp. Please review.

@AntonButov AntonButov changed the title fix test app Fix test app Sep 20, 2024
@JakeWharton
Copy link
Collaborator

I'll look Monday. Thanks

@JakeWharton
Copy link
Collaborator

I started to look at this, but I became concerned that merging this as-is will paper over a real problem. We have at least one workaround in place for the UInt problem (in the GuestProtocolAdapter), but obviously we're missing more. I don't want someone using UInt to get failures like this. We might need to outright reject it at the schema-level if it truly can't be worked around in the runtime.

@AntonButov
Copy link
Author

Certainly, this will be better for the users. The PR can be closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AntonButov @JakeWharton