-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding SPDX identifier for custom url #43
Comments
You can send a PR to add the link to the fallback list: licensee/src/main/kotlin/app/cash/licensee/licenses.kt Lines 61 to 70 in 41fd142
At present I do not plan on exposing the ability to change this list dynamically since ideally we are trending towards adhering to the URLs in the SPDX specification, or perhaps we should implore SPDX to allow multiple canonical URLs for a license. |
This link is just an example, in my app I have 15+ different links like those, some pointing to license file on library author site. Adding them all to the fallback list isn't probably what you mean. And suppressing stuff because "I've checked and that's MIT" doesn't scale very well on the library side. Don't get me wrong, this is a great library. But I though it will be an alternative to OSS Licenses Gradle Plugin. Right now it does the validation very well, but not the licenses screen part :( |
The plugin outputs a JSON file that you can use to power a license screen in your web, desktop, or mobile application. If they are relatively standard URLs the fallback list is where they should go. Otherwise you should encourage the libraries to migrate or simply allow the URL rather than the SPDX identifier it represents. |
Changing the pom files of the libraries is only possible if it is merged, the library is updated regularly and you can use this new version. |
@JakeWharton Do you accept a PR or are you still not convinced? |
Wanting to map custom URLs to existing IDs for the purpose of the JSON is pretty compelling. |
Can you provide a way to map a custom license url to a SPDX indentifier?
For example, one of our dependency has this license url:
https://opensource.org/licenses/mit-license
. It's pretty oblivious that this dependency has MIT license, but there is no way to pass this knowledge to the plugin. Something like:would be very helpful 🙂
The text was updated successfully, but these errors were encountered: