Support specification of private key to claimer #350
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tuler
force-pushed
the
feature/private-key
branch
2 times, most recently
from
93fbe8a to
8589b9c
Compare
tuler
force-pushed
the
feature/private-key
branch
from
8589b9c to
f645def
Compare
endersonmaia
requested changes
Mar 14, 2024
There was a problem hiding this comment.
It should also be possible to alternatively define a CARTESI_AUTH_PRIVATE_KEY_FILE, as we have for CARTESI_AUTH_MNEMONIC_FILE.
See: https://github.com/cartesi/rollups-node/blob/main/internal/config/generate/Config.toml#L154-L162
Done |
renan061
reviewed
Mar 14, 2024
renan061
reviewed
Mar 14, 2024
renan061
approved these changes
Mar 14, 2024
endersonmaia
requested changes
Mar 14, 2024
renan061
approved these changes
Mar 14, 2024
endersonmaia
approved these changes
Mar 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the option to specify CARTESI_AUTH_PRIVATE_KEY to pass to the authority-claimer in case the user have a simple private key in hand, and not a mnemonic.
The value of the private key must be a hex string of 32 bytes, without the traditional starting
0x.i.e.:
59c6995e998f97a5a0044966f0945389dc9e86dae88c7a8412f4603b6b78690dcloses #344