Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename fields in InputAdded event. #2

Closed
guidanoli opened this issue Aug 17, 2023 · 1 comment · Fixed by #201
Closed

Rename fields in InputAdded event. #2

guidanoli opened this issue Aug 17, 2023 · 1 comment · Fixed by #201
Assignees
@ZzzzHui
Labels
A-contracts Area: contracts T-debt Type: debt
Milestone
2.0.0

Comments

@guidanoli
Copy link
Collaborator

📚 Context

The IInputBox interface specifies an event called InputAdded.
We noticed that we could improve the naming of some of its arguments.

✔️ Solution

  • Rename inputIndex --> index
  • Rename input --> payload
@guidanoli guidanoli added the T-feature Type: feature label Aug 17, 2023
@guidanoli
Copy link
Collaborator Author

FYI @miltonjonat

@guidanoli guidanoli moved this to 📋 Backlog in Rollups Unit Aug 18, 2023
@guidanoli guidanoli added D-easy T-debt Type: debt A-contracts Area: contracts and removed T-feature Type: feature labels Aug 27, 2023
@guidanoli guidanoli added this to the 2.0.0 milestone Sep 18, 2023
@guidanoli guidanoli mentioned this issue Sep 28, 2023
Merged
@ZzzzHui ZzzzHui self-assigned this Oct 9, 2023
@ZzzzHui ZzzzHui linked a pull request Oct 9, 2023 that will close this issue
feat: blockchain agnostic inputs #89
Merged
@guidanoli guidanoli moved this from 📋 Backlog to 🏗 In progress in Rollups Unit Oct 11, 2023
@guidanoli guidanoli modified the milestones: 2.0.0, 3.0.0 Nov 22, 2023
@ZzzzHui ZzzzHui moved this from 🚧 In progress to 👀 Under review in Rollups Unit Nov 24, 2023
@guidanoli guidanoli mentioned this issue Jan 17, 2024
Merged
@guidanoli guidanoli linked a pull request Jan 17, 2024 that will close this issue
feat: improve documentation for off-chain developers #201
Merged
@guidanoli guidanoli modified the milestones: 3.0.0, 2.0.0 Jan 17, 2024
@guidanoli guidanoli removed a link to a pull request Jan 17, 2024
feat: blockchain agnostic inputs #89
Merged
@guidanoli guidanoli moved this from 👀 Under review to 🚀 Done in Rollups Unit Jan 17, 2024
@guidanoli guidanoli mentioned this issue Jan 17, 2024
Closed
@brunomenezes brunomenezes mentioned this issue Mar 8, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ZzzzHui ZzzzHui

Labels
A-contracts Area: contracts T-debt Type: debt
Projects
Rollups Unit
Status: 🚀 Done
Milestone
2.0.0
Development

Successfully merging a pull request may close this issue.

feat: improve documentation for off-chain developers cartesi/rollups-contracts
2 participants
@guidanoli @ZzzzHui