Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

need return statements in _find_neighbor() & _update_point() #69

Open
jGaboardi opened this issue Jul 8, 2024 · 0 comments
Open

need return statements in _find_neighbor() & _update_point() #69

jGaboardi opened this issue Jul 8, 2024 · 0 comments
Assignees
Labels

Comments

@jGaboardi
Copy link
Collaborator

  • Came across this while working on add type hints #55
  • Do does there actually need to be return statements in _find_neighbor()1 and _update_point()2? The values are being set to the data structure itself, and there appears to be nothing being return in the current functional codebase.
  • The unknown here is the currently commented out merge_closest()3 method that may in fact need to return a value
  • xref:

cc @gegen07

Footnotes

  1. https://github.com/carsonfarmer/fastpair/blob/d2b38aad4597ec5d2572a9b5d2abbd60905e92fe/fastpair/base.py#L226

  2. https://github.com/carsonfarmer/fastpair/blob/d2b38aad4597ec5d2572a9b5d2abbd60905e92fe/fastpair/base.py#L259

  3. https://github.com/carsonfarmer/fastpair/blob/d2b38aad4597ec5d2572a9b5d2abbd60905e92fe/fastpair/base.py#L265

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants